Skip to content

Add Bluetooth device UI and cast autoplay toggle#480

Merged
theovilardo merged 4 commits intobckp/cast-currentlyfrom
codex/implementar-ajustes-en-conectividad-bluetooth
Dec 10, 2025
Merged

Add Bluetooth device UI and cast autoplay toggle#480
theovilardo merged 4 commits intobckp/cast-currentlyfrom
codex/implementar-ajustes-en-conectividad-bluetooth

Conversation

@theovilardo
Copy link
Copy Markdown
Owner

Summary

  • show connected Bluetooth audio devices inside the cast sheet with distinct styling
  • update full player cast action to reflect the current connection type
  • add a setting to disable auto-play when connecting or disconnecting from cast and respect it in cast handoff logic

Testing

  • Not run (not requested)

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +335 to +339
private val disableCastAutoplay: StateFlow<Boolean> = userPreferencesRepository.disableCastAutoplayFlow
.stateIn(
scope = viewModelScope,
started = SharingStarted.WhileSubscribed(5000),
initialValue = false
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Respect cast auto-play preference

The new disableCastAutoplay flag is never populated from preferences: it is wrapped in stateIn(SharingStarted.WhileSubscribed) and not collected anywhere, so the state flow never starts and always stays at the default false. As a result, even after the user disables “Auto-play on cast connect/disconnect” in Settings, the transfer logic at cast handoff (shouldAutoPlayOnCast/shouldResumePlaying) still sees false and keeps auto-playing whenever playback was active. Consider eagerly collecting this flow or using SharingStarted.Eagerly so the stored preference is reflected.

Useful? React with 👍 / 👎.

This commit refactors several UI components within the CastBottomSheet for a cleaner and more dynamic presentation.

Key changes include:
- Redesigned `DeviceItem` to use a `Row` and `Column` layout instead of `ListItem`, improving alignment and spacing.
- Refined the `InfoTile` design with animated colors for the active state and a smooth corner shape.
- Adjusted padding, spacers, and corner rounding throughout the bottom sheet for a more polished look.
@theovilardo theovilardo merged commit 88ae093 into bckp/cast-currently Dec 10, 2025
@lostf1sh lostf1sh deleted the codex/implementar-ajustes-en-conectividad-bluetooth branch January 16, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant