Enhance cast sheet connectivity info 15220278969080433240#473
Merged
theovilardo merged 4 commits intobckp/cast-currentlyfrom Dec 9, 2025
Merged
Conversation
…atus * Consolidated the "Active Device" card subtitles into a single text line to avoid redundancy. * Redesigned Wi-Fi and Bluetooth indicators as large "Quick Settings" style pills and moved them to the top of the sheet. * Updated the "Turn on Wi-Fi" button to launch system Wi-Fi settings via `Settings.ACTION_WIFI_SETTINGS`. * Cleaned up unused `ServiceDot` component and previous indicator implementation.
- Added `ACCESS_FINE_LOCATION` and `ACCESS_COARSE_LOCATION` to `AndroidManifest.xml` to enable fetching the connected Wi-Fi SSID on Android 8.1+. - Updated `PlayerViewModel` to expose `wifiName` and `bluetoothName` StateFlows. - Implemented `ConnectivityManager.NetworkCallback` logic to attempt to retrieve SSID (gracefully handling redaction if permissions are missing). - Implemented `AudioManager.AudioDeviceCallback` to detect and display the name of connected Bluetooth audio devices (A2DP, SCO, BLE). - Updated `CastBottomSheet` UI: - `QuickSettingTile` now accepts a `subtitle` to display the connected network/device name or "On"/"Off". - Added click handlers to the Wi-Fi and Bluetooth tiles to open their respective system settings via Intents. - Updated layout to accommodate the new information.
- Added `ACCESS_FINE_LOCATION` and `ACCESS_COARSE_LOCATION` to `AndroidManifest.xml` to enable fetching the connected Wi-Fi SSID on Android 8.1+. - Updated `PlayerViewModel` to expose `wifiName` and `bluetoothName` StateFlows. - Implemented `ConnectivityManager.NetworkCallback` logic to attempt to retrieve SSID (gracefully handling redaction if permissions are missing). - Implemented `AudioManager.AudioDeviceCallback` to detect and display the name of connected Bluetooth audio devices (A2DP, SCO, BLE). - Updated `CastBottomSheet` UI: - `QuickSettingTile` now accepts a `subtitle` to display the connected network/device name or "On"/"Off". - Added click handlers to the Wi-Fi and Bluetooth tiles to open their respective system settings via Intents. - Updated layout to accommodate the new information.
This commit refactors and visually enhances the Cast bottom sheet and related player components. Key changes include: - Refined the visual design and layout of the "Connect device" card. - Updated color schemes and shapes for better consistency. - Removed the "Connecting..." text from the full player header. - Cleaned up and removed obsolete commented-out code.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
lostf1sh
deleted the
enhance-cast-sheet-connectivity-info-15220278969080433240
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.