Fix player UI disappearing during Cast transition#466
Fix player UI disappearing during Cast transition#466theovilardo merged 1 commit intobckp/cast-currentlyfrom
Conversation
…itions This change ensures a seamless visual transition between local and remote playback by: 1. Preventing `stablePlayerState.currentSong` from being nulled out during the handover process in `PlayerViewModel`, effectively persisting the last known song state. 2. Modifying `UnifiedPlayerSheet` to stay visible if `isCastConnecting` is true, even if the player temporarily reports no active song. 3. Adding a "Connecting..." visual state to both the Mini Player and Full Player components to provide immediate user feedback. 4. Delaying the reset of the `isCastConnecting` flag until the local player is fully restored when disconnecting from Cast.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Improved the visual stability of the player during Cast sessions. The player UI no longer disappears and reappears abruptly when connecting or disconnecting. Instead, it remains visible and displays a loading state. This was achieved by guarding state updates in the ViewModel to preserve song metadata during the transition and updating the visibility logic in the UI components.
PR created automatically by Jules for task 18336916506603950904 started by @theovilardo