Improve cast queue display and add cast connecting state#451
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Text( | ||
| text = if (isRemote) "Casting on" else "Playing on", | ||
| text = when { | ||
| isConnecting -> "Connecting to" | ||
| isRemote -> "Casting on" | ||
| else -> "Playing on" | ||
| }, |
There was a problem hiding this comment.
Add isConnecting parameter to CastStatusHeader
CastStatusHeader now references isConnecting and the caller passes an isConnecting argument, but the function signature still only accepts isRemote/routeName/isPlaying/onDisconnect/onRefresh. This makes the module fail to compile because isConnecting is undefined in the body and the call supplies an extra named argument. The signature needs an isConnecting: Boolean parameter (or the new usage removed) so the build succeeds.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task