Skip to content

Improve cast queue display and add cast connecting state#451

Merged
theovilardo merged 1 commit intobckp/cast-currentlyfrom
codex/adjust-ui-behavior-for-remote-playback
Dec 7, 2025
Merged

Improve cast queue display and add cast connecting state#451
theovilardo merged 1 commit intobckp/cast-currentlyfrom
codex/adjust-ui-behavior-for-remote-playback

Conversation

@theovilardo
Copy link
Copy Markdown
Owner

Summary

  • keep the queue UI using the full playlist during cast sessions instead of truncating to current and next items
  • add cast connection state management so the player stays visible while establishing remote playback
  • surface "connecting" indicators in the cast controls while sessions are being set up

Testing

  • Not run (not requested)

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 223 to +228
Text(
text = if (isRemote) "Casting on" else "Playing on",
text = when {
isConnecting -> "Connecting to"
isRemote -> "Casting on"
else -> "Playing on"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Add isConnecting parameter to CastStatusHeader

CastStatusHeader now references isConnecting and the caller passes an isConnecting argument, but the function signature still only accepts isRemote/routeName/isPlaying/onDisconnect/onRefresh. This makes the module fail to compile because isConnecting is undefined in the body and the call supplies an extra named argument. The signature needs an isConnecting: Boolean parameter (or the new usage removed) so the build succeeds.

Useful? React with 👍 / 👎.

@theovilardo theovilardo merged commit 32d4022 into bckp/cast-currently Dec 7, 2025
@lostf1sh lostf1sh deleted the codex/adjust-ui-behavior-for-remote-playback branch January 16, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant