fix(player): improve navigation and image handling#406
Merged
theovilardo merged 3 commits intotheovilardo:masterfrom Dec 4, 2025
Merged
fix(player): improve navigation and image handling#406theovilardo merged 3 commits intotheovilardo:masterfrom
theovilardo merged 3 commits intotheovilardo:masterfrom
Conversation
Collaborator
lostf1sh
commented
Dec 2, 2025
lostf1sh
commented
- Fix navigation to root folder in PlayerViewModel
- Fix default album art fallback in MiniPlayerContentInternal
- Improve playlist scrolling behavior in PlaylistContainer
- Update song sorting logic in MusicRepositoryImpl
- Simplify breadcrumbs navigation in LibraryActionRow
- Update error image handling in SmartImage and OptimizedAlbumArt
- Fix navigation to root folder in PlayerViewModel - Fix default album art fallback in MiniPlayerContentInternal - Improve playlist scrolling behavior in PlaylistContainer - Update song sorting logic in MusicRepositoryImpl - Simplify breadcrumbs navigation in LibraryActionRow - Update error image handling in SmartImage and OptimizedAlbumArt
…lbumArt The placeholder image was not properly sized, causing layout issues. Added a fixed size of 96.dp to ensure consistent appearance.
The fallback images (R.drawable.rounded_album_24) were removed from all SmartImage components as they are no longer needed. The image loading library now handles missing images with a dedicated placeholder (R.drawable.ic_music_placeholder) configured at the request level. This change simplifies the component usage and centralizes the fallback image handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.