Add configurable playlist transitions#405
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| when { | ||
| _uiState.value.useGlobalDefaults -> transitionRepository.deletePlaylistDefaultRule(playlistId) | ||
| ruleToSave != null && ruleToSave.settings.mode == TransitionMode.NONE -> | ||
| transitionRepository.deletePlaylistDefaultRule(playlistId) | ||
| } else { | ||
| transitionRepository.saveRule(ruleToSave) | ||
| } | ||
| ruleToSave != null -> transitionRepository.saveRule(ruleToSave) |
There was a problem hiding this comment.
When saving playlist-level changes, the when block deletes the playlist default whenever the selected mode is TransitionMode.NONE, which removes the override and causes the playlist to fall back to the global transition settings instead of actually disabling transitions for that playlist. With the new "use global defaults" toggle in the UI, this makes it impossible to keep a playlist-specific "no transitions" setting unless the global default is also NONE.
Useful? React with 👍 / 👎.
Make the curve cards in the EditTransition screen have equal width. Add the EditTransition screen to the list of screens where the navigation bar should be hidden.
1 participant
Summary
Testing
Codex Task