Fix NullPointerException crash when lyrics end#400
Merged
theovilardo merged 9 commits intotheovilardo:masterfrom Nov 27, 2025
Merged
Fix NullPointerException crash when lyrics end#400theovilardo merged 9 commits intotheovilardo:masterfrom
theovilardo merged 9 commits intotheovilardo:masterfrom
Conversation
…ove-animations Improve album art caching and player animations
Replace 'lyrics!!' null assertion with 'lyrics?.areFromRemote == true' to prevent crashes. Apply minor formatting and whitespace cleanup in LyricsSheet.
This reverts commit a373030.
This reverts commit 6d3b140.
- Replace lyrics!!.areFromRemote with lyrics?.areFromRemote == true - Footer lambda was being called by LazyColumn after lyrics became null - Safely handle null lyrics state when song ends or changes
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App was crashing with
NullPointerExceptionwhen lyrics finished playing. The crash occurred inLyricsSheet.ktat line 418 wherelyrics!!.areFromRemotewas being accessed.Cause
The
footerlambda passed toSyncedLyricsListwas being called byLazyColumnafter thelyricsstate had already become null (when song ends or changes).Solution
Replaced unsafe
lyrics!!.areFromRemotewith safe null checklyrics?.areFromRemote == true.Reverted my codex pr since its making it way worse.