Add GitHubContributorService to fetch and display contributors on AboutScreen#395
Add GitHubContributorService to fetch and display contributors on AboutScreen#395theovilardo merged 3 commits intotheovilardo:masterfrom
Conversation
…reen to display them
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val response = connection.inputStream.bufferedReader().use { it.readText() } | ||
| val contributors = json.decodeFromString<List<GitHubContributor>>(response) |
There was a problem hiding this comment.
GitHubContributorService won’t compile: json.decodeFromString at contributor parsing uses the reified serialization extension, but this file doesn’t import kotlinx.serialization.decodeFromString (or supply an explicit serializer), so the call is an unresolved reference and the module fails to build before any runtime behavior can be exercised.
Useful? React with 👍 / 👎.
|
Yeah, I also forgot to mention that this one won't show bots like Jules, only users. It's also more efficient than having to hardcode it manually every time a new contributor comes along. |
…b-actions Add GitHub Actions workflow to build APK
2 participants
This pull request introduces a new feature to dynamically fetch and display the list of project contributors from the GitHub API on the
AboutScreen, replacing the previously hardcoded contributors. The implementation includes a new service class for GitHub API integration, UI state management for loading and error handling, and updates to the contributor display logic.GitHub API integration:
GitHubContributorServiceandGitHubContributordata class to handle fetching and parsing contributor data from the GitHub API, filtering out bots and sorting by contributions. (app/src/main/java/com/theveloper/pixelplay/data/github/GitHubContributorService.kt)AboutScreen contributor section:
GitHubContributorService, converting API results to the localContributormodel and excluding the author from the list. (app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt)app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt)Dependency and logging updates:
Timber), and Hilt injection in the AboutScreen. (app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt)