Fix playlist item layout: Move 'more options' button to end of row#393
Fix playlist item layout: Move 'more options' button to end of row#393theovilardo merged 2 commits intomasterfrom
Conversation
In `PlaylistDetailScreen`, the "More Options" button for playlist items was incorrectly positioned, appearing floating on the left side of the item. This was due to the button code being placed in the top-level `BoxWithConstraints` of `QueuePlaylistSongItem`, causing it to default to the `TopStart` position and overlay other content. This commit moves the "More Options" button logic inside the main content `Row` of the item. This ensures: 1. The button is positioned at the end of the row (right side), as expected for a context menu action. 2. It appears visually after the song details and music visualizer, resolving the layout clash. 3. The button now moves correctly with the item during drag-and-drop reordering, as it is part of the `Surface` that receives the drag offset. The change is conditional on `isFromPlaylist`, ensuring that the `QueuePlaylistSongItem`'s usage in other screens (like the Queue bottom sheet) remains unaffected.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
1 participant
Moved the
isFromPlaylistconditional block containing theFilledIconButton("More Options") from the outerBoxWithConstraintsscope to the innerRowlayout inQueuePlaylistSongItemwithinQueueBottomSheet.kt. This fixes the issue where the button was overlaying content on the left side instead of being aligned to the right.PR created automatically by Jules for task 9982818842995268962 started by @theovilardo