Conversation
The drag gesture for the queue sheet was not working as expected. Wrapping the `QueueBottomSheet` within a `Box` composable and adding top padding to the drag handle resolves the issue.
The drag gesture for the queue sheet was not working as expected. Wrapping the `QueueBottomSheet` within a `Box` composable and adding top padding to the drag handle resolves the issue.
This commit refactors the "Save as playlist" dialog into a full-screen `ModalBottomSheet`. Key changes: - Converted the save playlist interface to a full-screen bottom sheet for a more immersive experience. - Improved the visual style by applying Material 3 guidelines, including updated colors, shapes, and component usage (`MediumTopAppBar`, `OutlinedTextField`, etc.). - Enhanced the UI by making the bottom "Save" bar rounded and cleaning up related code. - Replaced the `Filled.Add` icon with `Rounded.Add` for visual consistency.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fun endQueueDrag(totalDrag: Float, velocity: Float) { | ||
| if (queueHiddenOffsetPx == 0f) return | ||
| val isFastUpward = velocity < -650f | ||
| val isFastDownward = velocity > 650f | ||
| val shouldExpand = isFastUpward || (!isFastDownward && (queueSheetOffset.value < queueHiddenOffsetPx - queueDragThresholdPx || totalDrag < -queueDragThresholdPx)) |
There was a problem hiding this comment.
endQueueDrag (UnifiedPlayerSheet.kt lines 562-566) treats the sheet as “should expand” whenever queueSheetOffset is less than queueHiddenOffsetPx - queueDragThresholdPx, where queueDragThresholdPx is only 8% of the sheet height. From an open queue this condition stays true until the sheet is ~92% closed, so a normal downward swipe just snaps back open unless you fling >650px/s or drag almost the full height. This makes the queue almost impossible to dismiss by dragging; the threshold should be tied to a small drag distance/open fraction instead.
Useful? React with 👍 / 👎.
1 participant
No description provided.