Refactor: Decouple Library tab management from enum#283
Merged
theovilardo merged 1 commit intomasterfrom Oct 22, 2025
Merged
Conversation
This commit removes the `LibraryTabId` enum and refactors the library tab management to use string identifiers. This change decouples the tab state from a rigid enum structure, making it more flexible and easier to manage. Key changes: - Deleted the `LibraryTabId` enum and its associated test file. - `PlayerViewModel` now manages library tabs using a `StateFlow<List<String>>`. - State persistence and reordering logic now operate on lists of strings. - UI components, including `LibraryScreen` and `ReorderTabsSheet`, have been updated to consume string identifiers instead of the enum. - Simplified tab selection and data loading logic in `PlayerViewModel` based on the tab's index and string key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
LibraryTabIdenum and refactors the library tab management to use string identifiers. This change decouples the tab state from a rigid enum structure, making it more flexible and easier to manage.Key changes:
LibraryTabIdenum and its associated test file.PlayerViewModelnow manages library tabs using aStateFlow<List<String>>.LibraryScreenandReorderTabsSheet, have been updated to consume string identifiers instead of the enum.PlayerViewModelbased on the tab's index and string key.