Fix: Load library tabs by identifier and add missing import#218
Merged
theovilardo merged 1 commit intomasterfrom Oct 9, 2025
Merged
Fix: Load library tabs by identifier and add missing import#218theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
This commit addresses two issues identified during a code review: 1. The `onLibraryTabSelected` function was using hard-coded numeric indices to trigger lazy loading for library tabs. This caused a bug where reordering tabs would result in incorrect content being loaded (e.g., clicking on the "Albums" tab would load songs). The logic has been refactored to use the stable string identifier of the tab (e.g., "SONGS", "ALBUMS") to ensure the correct data is always loaded, regardless of tab order. The `_loadedTabs` state has been updated accordingly to store string identifiers instead of integer indices. 2. A missing `kotlinx.serialization.decodeFromString` import was causing a compilation error. The import has been added to resolve this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two issues identified during a code review:
The
onLibraryTabSelectedfunction was using hard-coded numeric indices to trigger lazy loading for library tabs. This caused a bug where reordering tabs would result in incorrect content being loaded (e.g., clicking on the "Albums" tab would load songs). The logic has been refactored to use the stable string identifier of the tab (e.g., "SONGS", "ALBUMS") to ensure the correct data is always loaded, regardless of tab order. The_loadedTabsstate has been updated accordingly to store string identifiers instead of integer indices.A missing
kotlinx.serialization.decodeFromStringimport was causing a compilation error. The import has been added to resolve this issue.