Merged
Conversation
This commit introduces several enhancements to the album art carousel: 1. **Enable Scrolling for "No Peek" Mode:** The carousel in "No Peek" mode is now swipeable, allowing users to navigate between tracks even when no other items are peeking. 2. **Implement "Two Peeks" Layout:** A new layout for the "Two Peeks" style has been implemented. It now shows the current album art in the center, with peeks of both the previous and next album art on the sides, as requested. This was achieved by defining a custom `[small, large, small]` keyline list. 3. **Dynamic Height Adjustment:** The carousel's height is now dynamically calculated based on the selected style (`No Peek`, `One Peek`, or `Two Peeks`) to ensure the main album art always maintains a 1:1 aspect ratio. This is handled by wrapping the carousel in a `BoxWithConstraints` and adjusting the height based on the available width and the main item's size in each style.
This commit introduces several UI refinements to the `UnifiedPlayerSheet` and its components for better visual consistency and layout.
1. **Themed Track Volume Bottom Sheet:**
* The `TrackVolumeBottomSheet` now accepts a `ColorScheme` via a `CompositionLocalProvider`.
* This ensures that the bottom sheet's background, slider, and text colors correctly reflect the dynamic theme of the current album art, rather than defaulting to the app's base theme.
2. **Layout Padding Adjustments:**
* The vertical padding in several areas of the `UnifiedPlayerSheet` has been reduced or eliminated, particularly when the sheet is fully expanded. This creates a more compact and polished appearance by removing unnecessary empty space.
* The lyrics button code, which was commented out, has been completely removed to clean up the file.
This commit introduces several UI refinements to improve visual consistency and user experience.
- **`TrackVolumeBottomSheet.kt`:**
- The bottom sheet's background color is now `secondaryContainer` for better theming alignment.
- The "Volume" text color is updated to `secondary` to match the new background.
- A standard `DragHandle` has been added to the bottom sheet, improving discoverability and adhering to Material Design guidelines.
- **`SettingsScreen.kt`:**
- The "Two Peeks" option for the album carousel style has been removed, simplifying the available choices for the user.
- The "Carousel Style" settings item has been moved to the end of the "UI" section for better logical grouping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.