Skip to content

Added more informative error message when lrclib returns a 404.#203

Merged
theovilardo merged 1 commit intotheovilardo:masterfrom
SjVer:master
Oct 7, 2025
Merged

Added more informative error message when lrclib returns a 404.#203
theovilardo merged 1 commit intotheovilardo:masterfrom
SjVer:master

Conversation

@SjVer
Copy link
Copy Markdown
Contributor

@SjVer SjVer commented Oct 7, 2025

If lyrics are not found lrclib returns a 404, which raises an exception. Instead of reporting en error to the user, it now checks for that case and reports that the lyrics simply weren't found if appropiate.

A nitpick to be sure, but it makes it a tad less confusing IMO.

Cheers!

@SjVer
Copy link
Copy Markdown
Contributor Author

SjVer commented Oct 7, 2025

By the way, @theovilardo, is using lrclib's /api/search endpoint when /api/get comes up empty a planned feature? I'm thinking that it'd be nice if the user could opt for a more general lyrics search (using that method) when the initial search comes up empty.

I could probably add that feature myself and PR it too if you'd like, would be fun to do.

@theovilardo theovilardo merged commit 05813ab into theovilardo:master Oct 7, 2025
@theovilardo
Copy link
Copy Markdown
Owner

By the way, @theovilardo, is using lrclib's /api/search endpoint when /api/get comes up empty a planned feature? I'm thinking that it'd be nice if the user could opt for a more general lyrics search (using that method) when the initial search comes up empty.

I could probably add that feature myself and PR it too if you'd like, would be fun to do.

Hi there! Thanks for your contribution, it's very much appreciated and you are correct I was actually trying add that feature to the search page as LRCLIB often provides different variations of lyrics, but I delayed due to some other bugs and I left the endpoint there, if you want to implement it you're more than welcome of course 👐

@SjVer
Copy link
Copy Markdown
Contributor Author

SjVer commented Oct 7, 2025

By the way, @theovilardo, is using lrclib's /api/search endpoint when /api/get comes up empty a planned feature? I'm thinking that it'd be nice if the user could opt for a more general lyrics search (using that method) when the initial search comes up empty.
I could probably add that feature myself and PR it too if you'd like, would be fun to do.

Hi there! Thanks for your contribution, it's very much appreciated and you are correct I was actually trying add that feature to the search page as LRCLIB often provides different variations of lyrics, but I delayed due to some other bugs and I left the endpoint there, if you want to implement it you're more than welcome of course 👐

What were you planning on making the flow like?

It could either automatically look for- and present the results of a general search if it cannot find an exact match, or the user could be presented with an option to peform that search if no lyrics are found.

What do you want? Implicit or explicit search?

@theovilardo
Copy link
Copy Markdown
Owner

I think both are great options but I'm interested in the user being able to choose from the given options like if the lyrics are explicit or not, maybe with some sort of filter for that

@SjVer
Copy link
Copy Markdown
Contributor Author

SjVer commented Oct 7, 2025

Oh I don't even know if lrclib supports that. By 'explicit' I meant wether the user is told that /api/get failed and /api/search can be tried, or if that happens automatically (when get fails) without prompting the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants