Added more informative error message when lrclib returns a 404.#203
Added more informative error message when lrclib returns a 404.#203theovilardo merged 1 commit intotheovilardo:masterfrom
Conversation
|
By the way, @theovilardo, is using lrclib's I could probably add that feature myself and PR it too if you'd like, would be fun to do. |
Hi there! Thanks for your contribution, it's very much appreciated and you are correct I was actually trying add that feature to the search page as LRCLIB often provides different variations of lyrics, but I delayed due to some other bugs and I left the endpoint there, if you want to implement it you're more than welcome of course 👐 |
What were you planning on making the flow like? It could either automatically look for- and present the results of a general search if it cannot find an exact match, or the user could be presented with an option to peform that search if no lyrics are found. What do you want? Implicit or explicit search? |
|
I think both are great options but I'm interested in the user being able to choose from the given options like if the lyrics are explicit or not, maybe with some sort of filter for that |
|
Oh I don't even know if lrclib supports that. By 'explicit' I meant wether the user is told that |
If lyrics are not found lrclib returns a 404, which raises an exception. Instead of reporting en error to the user, it now checks for that case and reports that the lyrics simply weren't found if appropiate.
A nitpick to be sure, but it makes it a tad less confusing IMO.
Cheers!