Merged
Conversation
Removes redundant conditional logic that was causing a visual glitch in the navigation bar. The `conditionalShape` variable was incorrectly applying a large corner radius, leading to unwanted transparency effects. The fix simplifies the code by using the `actualShape` variable directly, which correctly calculates the navigation bar's shape based on the player's state and user settings. This ensures a consistent and correct appearance across all relevant screens.
A visual glitch was causing the navigation bar to become semi-transparent on certain screens when the mini-player was visible. This was due to the `graphicsLayer` not having an explicit alpha value, leading to unintended transparency. This patch resolves the issue by explicitly setting `alpha = 1.0f` on the `graphicsLayer` containing the navigation bar in `MainActivity.kt`. This ensures the navigation bar remains fully opaque, fixing the visual glitch without affecting screens where it is intentionally hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.