Merged
Conversation
This commit refines the screen transitions to provide a more "premium" and fluid user experience, in line with Material 3 expressive guidelines. The changes include: - Increasing the transition duration to 500ms. - Adding `scaleIn` and `scaleOut` effects to the enter and exit transitions respectively. - Adjusting the slide-in and slide-out offsets to be more subtle. - The initial request to animate the corner radius was not implemented due to technical limitations in the Jetpack Compose Navigation library.
This commit introduces haptic feedback to the `WavyMusicSlider` component. - When the slider value changes, it now triggers `HapticFeedbackType.TextHandleMove`. - The feedback is provided at each discrete step of the slider (approximated to 100 steps across the full range). Additionally, the shuffle icon in `GenreDetailScreen` has been updated from `Filled.Shuffle` to `Rounded.Shuffle`.
This commit adjusts the bottom padding calculation in the `HomeScreen` to prevent content from being obscured by the navigation bar and mini-player. Previously, `NavBarContentHeight` was incorrectly included in the `contentPadding` calculation, leading to excessive padding. This has been removed to ensure the correct spacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.