Merged
Conversation
This commit introduces several enhancements to the mini-player dismissal and undo functionality.
1. **Haptic Feedback on Dismiss Snap:**
Adds haptic feedback at the exact moment the swipe-to-dismiss gesture snaps from the "tension" phase to the "free drag" phase, providing a more tactile and satisfying user experience.
2. **Undo Bar Visibility and Animation:**
The "Undo" bar is now correctly displayed after dismissing the mini-player. It has been moved from the player sheet to the main activity to ensure it renders above the navigation bar in all modes. The bar now animates in by sliding up from the bottom of the screen.
3. **Undo Bar Close Button:**
A close button has been added to the "Undo" bar, allowing users to dismiss it immediately without waiting for the timeout. A corresponding function has been added to the ViewModel to handle this action.
This commit introduces several minor visual and stylistic changes:
- **DismissUndoBar:**
- Updated the "Close" icon to `Icons.Rounded.Close`.
- Styled the "Close" button as a `FilledIconButton` with a `surfaceContainerLow` background.
- Adjusted padding and text style for a more compact look.
- The bar itself now uses `CircleShape` and is constrained to `MiniPlayerHeight` with horizontal padding applied to its modifier.
- **AboutScreen:**
- Replaced the app icon with `pixelplay_base_monochrome.xml`.
- Removed the explicit scaling of the app icon.
- **UnifiedPlayerSheet:**
- Ensured `LocalHapticFeedback.current` is initialized once at the component level to avoid redundant calls.
- **Changelog:**
- Updated changelog text to reflect recent changes, including haptic feedback and M3E animations for the player, and fixing navigation bar padding.
- **MainActivity:**
- Standardized padding for the `DismissUndoBar` to match its updated internal padding.
- Updated "Preparing your library..." and permission request texts to English.
- **New Assets:**
- Added `pixelplay_base_monochrome.xml` (app icon).
- Added `theveloper_icon.png`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.