Merged
Conversation
This commit implements a feature where the miniplayer's corners become fully rounded when the navigation bar is hidden and in DEFAULT mode. - Added an `isNavBarHidden` parameter to the `UnifiedPlayerSheet` composable. - Passed the `shouldHideNavigationBar` state from `MainActivity` to the `UnifiedPlayerSheet`. - Updated the corner radius calculation logic in `UnifiedPlayerSheet` to apply a 32.dp radius when the navbar is hidden in DEFAULT mode, ensuring the change is animated.
This commit implements a feature where the miniplayer's corners become fully rounded when the navigation bar is hidden and in DEFAULT mode. - Added an `isNavBarHidden` parameter to the `UnifiedPlayerSheet` composable. - Passed the `shouldHideNavigationBar` state from `MainActivity` to the `UnifiedPlayerSheet`. - Updated the corner radius calculation logic in `UnifiedPlayerSheet` to apply a 32.dp radius when the navbar is hidden in DEFAULT mode, ensuring the change is animated. This is achieved by introducing a `collapsedRadius` variable that is used in the `lerp` function, preserving the animation.
This commit implements a feature where all four of the miniplayer's corners become fully rounded (60.dp) when the navigation bar is hidden and in DEFAULT mode. - Added an `isNavBarHidden` parameter to the `UnifiedPlayerSheet` composable. - Passed the `shouldHideNavigationBar` state from `MainActivity` to the `UnifiedPlayerSheet`. - Updated the top and bottom corner radius calculation logic in `UnifiedPlayerSheet` to apply a 60.dp radius when the navbar is hidden in DEFAULT mode, ensuring the change is animated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.