refactor: Optimize navigation bar padding calculation#136
Merged
theovilardo merged 1 commit intomasterfrom Sep 9, 2025
Merged
Conversation
This commit refactors the calculation of horizontal padding for the navigation bar in `MainActivity.kt`. The `systemNavBarInset` and `horizontalPadding` variables are now calculated once at a higher scope within the `MainActivity` composable, rather than being recalculated inside the `Scaffold`'s `bottomBar` lambda. This improves efficiency by avoiding redundant computations during recomposition. The `navBarStyle` is also collected as state at this higher scope to be used in the padding calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the calculation of horizontal padding for the navigation bar in
MainActivity.kt.The
systemNavBarInsetandhorizontalPaddingvariables are now calculated once at a higher scope within theMainActivitycomposable, rather than being recalculated inside theScaffold'sbottomBarlambda. This improves efficiency by avoiding redundant computations during recomposition.The
navBarStyleis also collected as state at this higher scope to be used in the padding calculation.