perf: optimize LibraryScreen state management and recompositions#1193
Merged
theovilardo merged 1 commit intomasterfrom Feb 22, 2026
Merged
perf: optimize LibraryScreen state management and recompositions#1193theovilardo merged 1 commit intomasterfrom
LibraryScreen state management and recompositions#1193theovilardo merged 1 commit intomasterfrom
Conversation
- **State Management**:
- Introduce `LibraryScreenPlayerProjection` data class to encapsulate only the necessary UI state from `PlayerViewModel`, reducing unnecessary recompositions.
- Use `distinctUntilChanged()` and `map` on state flows to ensure the UI only reacts to relevant data changes.
- Refactor `BackHandler` and loading overlay logic to use memoized state collectors (`canNavigateBackInFolders`, `isLibraryContentEmpty`).
- **Performance**:
- Replace broad `playerUiState` collection with a scoped projection within the `Scaffold` content.
- Optimize empty state detection by combining `allSongsFlow`, `albumsFlow`, and `artistsFlow` reactively.
- **UI/UX**:
- Ensure loading overlays for AI metadata generation and library syncing respect the optimized state projections.
- Clean up redundant state declarations and unused imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibraryScreenPlayerProjectiondata class to encapsulate only the necessary UI state fromPlayerViewModel, reducing unnecessary recompositions.distinctUntilChanged()andmapon state flows to ensure the UI only reacts to relevant data changes.BackHandlerand loading overlay logic to use memoized state collectors (canNavigateBackInFolders,isLibraryContentEmpty).playerUiStatecollection with a scoped projection within theScaffoldcontent.allSongsFlow,albumsFlow, andartistsFlowreactively.