perf: migration to lifecycle-aware state collection in Compose#1192
Merged
theovilardo merged 2 commits intomasterfrom Feb 22, 2026
Merged
perf: migration to lifecycle-aware state collection in Compose#1192theovilardo merged 2 commits intomasterfrom
theovilardo merged 2 commits intomasterfrom
Conversation
- Replace `collectAsState()` with `collectAsStateWithLifecycle()` across the entire presentation layer to ensure resource-efficient state collection. - Impacted screens and components include `LibraryScreen`, `PlayerSheet`, `HomeScreen`, `Settings`, `Search`, and various detail views (Artist, Album, Genre, Playlist). - Update `MainActivity` and `ExternalPlayerActivity` to use lifecycle-aware collection for theme and setup state. - Add `androidx.lifecycle:lifecycle-runtime-compose` dependency to `app/build.gradle.kts` and version catalog. - **MainViewModel**: Update `isSetupComplete` to use `Boolean?` with a `null` initial value to distinguish between "loading" and "incomplete" states during app startup. - **MainActivity**: Refactor setup screen visibility logic to prevent flickering by explicitly checking for the `null` initialization state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collectAsState()withcollectAsStateWithLifecycle()across the entire presentation layer to ensure resource-efficient state collection.LibraryScreen,PlayerSheet,HomeScreen,Settings,Search, and various detail views (Artist, Album, Genre, Playlist).MainActivityandExternalPlayerActivityto use lifecycle-aware collection for theme and setup state.androidx.lifecycle:lifecycle-runtime-composedependency toapp/build.gradle.ktsand version catalog.isSetupCompleteto useBoolean?with anullinitial value to distinguish between "loading" and "incomplete" states during app startup.nullinitialization state.