fix: Correct song ID format in Netease playlist sync#1183
Merged
theovilardo merged 1 commit intotheovilardo:masterfrom Feb 21, 2026
Merged
fix: Correct song ID format in Netease playlist sync#1183theovilardo merged 1 commit intotheovilardo:masterfrom
theovilardo merged 1 commit intotheovilardo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Fixes empty playlists issue when syncing Netease Cloud playlists to app playlists.
Root Cause
The previous implementation used incorrect song ID format when populating app playlists. Netease songs in the unified library use negative Long IDs (format:
-(NETEASE_SONG_ID_OFFSET + neteaseId)), but the playlist sync was storing incompatible ID formats that couldn't match database records.Solution
Changed
updateAppPlaylistForNeteasePlaylist()to use the correct unified song ID format:"netease_${entity.id}"→ Incompatible string formattoUnifiedSongId(entity.neteaseId).toString()→ Matches SongEntity IDsThis ensures playlist song IDs reference the same negative Long IDs stored in the unified library, allowing
getSongsByIds()to correctly retrieve songs.Technical Details
updateAppPlaylistForNeteasePlaylist()toUnifiedSongId()methodPlaylist.songIdstype requirementsyncUnifiedLibrarySongsFromNetease()logicImpact
✅ Netease playlist songs now display correctly in app playlists
✅ All playlist operations (play, shuffle, etc.) work as expected
✅ No changes to database schema or API contracts
Testing
Related to
Follows up on #[1182] - Netease playlist sync feature