perf: improve artwork handling and adjust crossfade defaults#1163
Merged
theovilardo merged 1 commit intomasterfrom Feb 21, 2026
Merged
perf: improve artwork handling and adjust crossfade defaults#1163theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
- **Player & UI**:
- Wrap `SmartImage` in a `key(song.id)` block within `UnifiedPlayerSheet` to ensure correct image recomposition when the song changes.
- Update `SmartImage` to reset its cached `lastSuccessPainter` when the image request data changes.
- Refactor `PlayerViewModel.resolveSongFromMediaItem` to prioritize global library state and implement `normalizeArtworkForResolvedSong` to sync `Song` metadata with `MediaItem` artwork URIs.
- **Settings & Defaults**:
- Disable crossfade by default and reduce the default duration from 6000ms to 2000ms.
- Expand the minimum allowed crossfade duration from 2000ms to 1000ms in `SettingsCategoryScreen`.
- Apply duration constraints (1s–12s) and updated defaults across `UserPreferencesRepository` and `TransitionSettings`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmartImagein akey(song.id)block withinUnifiedPlayerSheetto ensure correct image recomposition when the song changes.SmartImageto reset its cachedlastSuccessPainterwhen the image request data changes.PlayerViewModel.resolveSongFromMediaItemto prioritize global library state and implementnormalizeArtworkForResolvedSongto syncSongmetadata withMediaItemartwork URIs.SettingsCategoryScreen.UserPreferencesRepositoryandTransitionSettings.