refactor: replace navController.navigate with navigateSafely acro…#1160
Merged
theovilardo merged 1 commit intomasterfrom Feb 20, 2026
Merged
refactor: replace navController.navigate with navigateSafely acro…#1160theovilardo merged 1 commit intomasterfrom
navController.navigate with navigateSafely acro…#1160theovilardo merged 1 commit intomasterfrom
Conversation
…ss all screens
- **Navigation**:
- Implement `navigateSafely` across major screens including `HomeScreen`, `LibraryScreen`, `SearchScreen`, `AlbumDetailScreen`, `ArtistDetailScreen`, and `SettingsScreen` to ensure more robust navigation transitions.
- Update `MainActivity` to use `navigateSafely` with a retry mechanism for pending playlist navigation.
- Update `PlayerInternalNavigationBar` and `Drawer` components to use safe navigation.
- **UI Components**:
- Refactor `PlaylistContainer`, `SheetActionHandlers`, and `PlayerArtistNavigationEffect` to utilize the new safe navigation extension.
- Ensure all bottom sheet "Navigate to Artist/Album" actions use `navigateSafely`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ss all screens
navigateSafelyacross major screens includingHomeScreen,LibraryScreen,SearchScreen,AlbumDetailScreen,ArtistDetailScreen, andSettingsScreento ensure more robust navigation transitions.MainActivityto usenavigateSafelywith a retry mechanism for pending playlist navigation.PlayerInternalNavigationBarandDrawercomponents to use safe navigation.PlaylistContainer,SheetActionHandlers, andPlayerArtistNavigationEffectto utilize the new safe navigation extension.navigateSafely.