Merged
Conversation
- **Feature: Custom Artist Images**
- Users can now set a custom image for any artist from the Artist Detail screen.
- An "Edit" button on the artist header opens a menu to "Change photo" (via system photo picker) or "Reset to default".
- Selected images are copied to internal app storage to ensure persistence and compressed as JPEGs to save space.
- **Database & Data Layer**:
- The `artists` table is updated with a `custom_image_uri` column via a new database migration (v22 to v23).
- `MusicDao` includes new methods (`updateArtistCustomImage`, `getArtistCustomImage`) and updates existing queries to select the new field.
- `ArtistImageRepository` is expanded with logic to set, clear, and resolve the effective artist image, prioritizing the user's custom image over the one from the Deezer API.
- **UI & Theming**:
- The `ArtistDetailScreen` now uses a `MaterialTheme` whose color scheme is dynamically generated from the artist's image.
- The `ArtistDetailViewModel` pre-warms this color palette before the UI loads to prevent a flash of default colors.
- The UI state now tracks `effectiveImageUrl` (custom or remote) to ensure the correct image is always displayed.
- The view model and repository now handle the full lifecycle of setting/clearing custom images and regenerating the theme palette accordingly.
- Ensure `SongInfoBottomSheet` and `PlaylistSelectorBottomSheet` in `ArtistDetailScreen` inherit the artist's dynamic color palette by moving them inside the `MaterialTheme` scope. - Align bottom sheet styling behavior with `AlbumDetailScreen`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.