Merged
Conversation
…Bar` component
- **Components**:
- Introduce `CollapsibleCommonTopBar`, a reusable component that handles background interpolation, back navigation, and customizable action rows.
- Support flexible title padding and `maxLines` configuration to match existing screen designs.
- **Screens**:
- Replace screen-specific top bar implementations (e.g., `SettingsTopBar`, `EqualizerTopBar`, `AboutTopBar`, `StatsTopBar`) with the unified `CollapsibleCommonTopBar`.
- Refactor `EqualizerScreen` to pass view mode and power toggle buttons as actions to the new top bar.
- Refactor `DelimiterConfigScreen` to pass the reset button as a top bar action.
- Standardize content padding across `Settings`, `About`, `Equalizer`, `ExperimentalSettings`, and `DeviceCapabilities` screens by adding an 8.dp offset to `LazyColumn` top padding.
- **Styling**:
- Improve visual consistency of the collapsing background using a standard `surfaceContainer` color with alpha interpolation.
- Ensure back buttons consistently use `surfaceContainerLow` as the background color.
…ings screens
- **StatsScreen**:
- Reduce top content padding and remove unnecessary background spacer below tabs to create a more compact layout.
- Update top bar background to use `surfaceContainerHigh` for better visual elevation when collapsed.
- Adjust `ScrollableTabRow` edge padding from 20.dp to 12.dp and set background to transparent.
- **AboutScreen**:
- Update `CollapsibleCommonTopBar` horizontal padding, reducing expanded start padding to 20.dp and increasing collapsed start padding to 68.dp for better alignment.
- **ArtistSettingsScreen**:
- Increase expanded title start padding from 0.dp to 20.dp to match other screens.
- **CollapsibleCommonTopBar**:
- Change default background color from `surfaceContainer` to `surfaceContainerHigh`.
- **Resources**: Add `rounded_developer_board_24.xml` vector drawable.
- **Settings**: Update the icon for the "Device Capabilities" category from `Icons.Rounded.Info` to `Icons.Rounded.DeveloperBoard`.
- **UI Components**:
- **QueueBottomSheet**: Replace the `Icons.Rounded.Add` icon with `Icons.Rounded.MoreHoriz` for queue actions and remove the rotation modifier.
- **DeviceCapabilitiesScreen**: Remove a redundant comment in the layout file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.