Added BackHandler support to SettingsCategoryScreen#1083
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Settings category screen to handle system back presses by collapsing the expanded player bottom sheet instead of immediately navigating away, aligning behavior with other screens that integrate the unified player sheet.
Changes:
- Collect
playerViewModel.sheetStateinSettingsCategoryScreen. - Add a
BackHandlerthat collapses the player sheet when it’s expanded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/com/theveloper/pixelplay/presentation/screens/SettingsCategoryScreen.kt
Show resolved
Hide resolved
lostf1sh
changed the title
lostf1sh
deleted the
codex/fix-fullscreen-player-background-gesture-behavior
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added BackHandler support to SettingsCategoryScreen so category pages (like Appearance/Playback) now intercept back gestures when the full player is expanded. This ensures back collapses the player first instead of navigating away from the current settings page.