feat: implement "start at zero" shuffle and refine playback logic#1075
Merged
theovilardo merged 1 commit intomasterfrom Feb 14, 2026
Merged
feat: implement "start at zero" shuffle and refine playback logic#1075theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
- **Queue Management**:
- Add `generateShuffleOrderStartAtZero` to `QueueUtils` to ensure a specific anchor song always occupies the first position in a shuffled queue.
- Update `buildAnchoredShuffleQueueSuspending` and `QueueStateHolder` to support the new `startAtZero` shuffle behavior.
- **Player Logic**:
- Modify `PlayerViewModel.playSongsShuffled` to accept an optional `startAtZero` parameter.
- Remove strict `openInputStream` validation in `PlayerViewModel` to prevent valid songs from being incorrectly filtered out due to transient access issues.
- **Artist Detail UI**:
- Update the shuffle/play button in `ArtistDetailScreen` to use the new `playSongsShuffled` logic with `startAtZero = true` for a more consistent playback experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue Management:
generateShuffleOrderStartAtZerotoQueueUtilsto ensure a specific anchor song always occupies the first position in a shuffled queue.buildAnchoredShuffleQueueSuspendingandQueueStateHolderto support the newstartAtZeroshuffle behavior.Player Logic:
PlayerViewModel.playSongsShuffledto accept an optionalstartAtZeroparameter.openInputStreamvalidation inPlayerViewModelto prevent valid songs from being incorrectly filtered out due to transient access issues.Artist Detail UI:
ArtistDetailScreento use the newplaySongsShuffledlogic withstartAtZero = truefor a more consistent playback experience.