Merged
Conversation
…ers and refine UI transitions
- **Gesture Handling**:
- Add `onDragCancel` to `SheetVerticalDragGestureHandler` to ensure consistent state cleanup.
- Track `isSheetDragGestureActive` across player components to coordinate placeholder transitions with user interaction.
- **Placeholder Logic**:
- Introduce `switchOnDragRelease` preference to defer content/placeholder swapping until a drag gesture is finished, bypassing percentage-based thresholds.
- Update `DelayedContent` to handle the new drag-release logic, ensuring placeholders only transition when the sheet is stable.
- **Settings & Preferences**:
- Add "Switch on drag release" toggle to Experimental Settings.
- Enable `usePlayerSheetV2` by default.
- Update `UserPreferencesRepository` and `SettingsViewModel` to persist and manage the new preference.
- **UI Refinements**:
- Adjust corner radius interpolation in `SheetVisualState` to transition to `0.dp` when fully expanded for a more immersive look.
- Disable threshold sliders in settings when "Switch on drag release" is active to prevent conflicting configurations.
…ers and refine UI transitions
- **Gesture Handling**:
- Add `onDragCancel` to `SheetVerticalDragGestureHandler` to ensure consistent state cleanup.
- Track `isSheetDragGestureActive` across player components to coordinate placeholder transitions with user interaction.
- **Placeholder Logic**:
- Introduce `switchOnDragRelease` preference to defer content/placeholder swapping until a drag gesture is finished, bypassing percentage-based thresholds.
- Update `DelayedContent` to handle the new drag-release logic, ensuring placeholders only transition when the sheet is stable.
- **Settings & Preferences**:
- Add "Switch on drag release" toggle to Experimental Settings.
- Enable `usePlayerSheetV2` by default.
- Update `UserPreferencesRepository` and `SettingsViewModel` to persist and manage the new preference.
- **UI Refinements**:
- Adjust corner radius interpolation in `SheetVisualState` to transition to `0.dp` when fully expanded for a more immersive look.
- Disable threshold sliders in settings when "Switch on drag release" is active to prevent conflicting configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.