perf: optimize playback state updates and recomposition frequency#1044
Merged
theovilardo merged 1 commit intomasterfrom Feb 12, 2026
Merged
perf: optimize playback state updates and recomposition frequency#1044theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
- **State Management**:
- Introduced `stablePlayerStateInfrequent` in `PlayerViewModel` to decouple structural playback changes (song, play/pause) from high-frequency position updates, reducing unnecessary recompositions across most screens.
- Added `currentPlaybackPosition` flow for components requiring real-time updates (seek bars, lyrics).
- Updated `PlaybackStateHolder` to suppress redundant state updates when values are unchanged.
- **UI & Performance**:
- Migrated major screens (`Home`, `Library`, `AlbumDetail`, `PlaylistDetail`, etc.) to use `stablePlayerStateInfrequent`.
- Refactored `UnifiedPlayerSheet` and `LyricsSheet` to use granular position flows instead of the full UI state.
- Quantized position strings in `FullPlayerContent` to update only every second, minimizing UI churn.
- **Accessibility & Controls**:
- Implemented accessibility semantics for `WavySliderExpressive` and `WavyMusicSlider`, including `semanticsLabel` and quantized `ProgressBarRangeInfo` to reduce accessibility event noise.
- Refined haptic feedback granularity in `WavyMusicSlider`.
- **Animations**:
- Replaced `InfiniteTransition` with manual `Animatable` loops in `PlayingEqIcon` to allow clean pausing/resuming of animations based on playback state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State Management:
stablePlayerStateInfrequentinPlayerViewModelto decouple structural playback changes (song, play/pause) from high-frequency position updates, reducing unnecessary recompositions across most screens.currentPlaybackPositionflow for components requiring real-time updates (seek bars, lyrics).PlaybackStateHolderto suppress redundant state updates when values are unchanged.UI & Performance:
Home,Library,AlbumDetail,PlaylistDetail, etc.) to usestablePlayerStateInfrequent.UnifiedPlayerSheetandLyricsSheetto use granular position flows instead of the full UI state.FullPlayerContentto update only every second, minimizing UI churn.Accessibility & Controls:
WavySliderExpressiveandWavyMusicSlider, includingsemanticsLabeland quantizedProgressBarRangeInfoto reduce accessibility event noise.WavyMusicSlider.Animations:
InfiniteTransitionwith manualAnimatableloops inPlayingEqIconto allow clean pausing/resuming of animations based on playback state.