Merged
Conversation
- **Recently Played Section**:
- The section on the home screen is now only displayed if there are at least 4 recently played songs, preventing it from showing with too few items.
- Implemented a more balanced algorithm for distributing song pills across the three rows, ensuring a more staggered and visually appealing layout.
- The logic for determining pill widths has been simplified by removing the row-based stagger offset.
- Added `key()` to each pill to improve performance and state management during recomposition.
- **Recently Played Screen**:
- Updated the font style for the screen title, adjusting weight and width for a bolder appearance.
- Refined the time range filter chips with new colors, increased height, and adjusted icon padding for better visual hierarchy.
- **Data Handling**:
- The playback history is now sorted first by timestamp (descending) and then by song ID (ascending) to ensure a stable, deterministic order for deduplication.
- **UI Polish**:
- Vertically centered the content within the `BottomToggleRow` component in the full player for improved alignment.
- Adjusted padding on the `RecentlyPlayedPill` to correctly calculate the album art's position.
…sion
- **PlayerViewModel**: Implement logic to disconnect remote playback when dismissing the player. This ensures that if a Cast session is active or connecting, it is terminated along with the local player state.
- **CastTransferStateHolder**:
- Add `skipNextTransferBack()` to allow one-shot disconnection of Cast without restoring the remote queue to the local player.
- Update `stopServerAndTransferBack()` to respect the `skipTransferBackOnNextSessionEnd` flag, skipping the heavy queue rebuilding and local player synchronization logic when requested.
- Ensure the skip flag is reset after use and during cleanup.
- **Settings**:
- Add "Show player file info" toggle to `SettingsCategoryScreen` to control the visibility of codec, bitrate, and sample rate.
- Relocate "Player Gestures" subsection from the appearance category to the behavior category for better organization.
- **Player UI**:
- Update `FullPlayerContent` to conditionally display the audio metadata chip based on the new user preference.
- Synchronize loading placeholders to respect the file info visibility setting.
- **Data & State**:
- Introduce `FULL_PLAYER_SHOW_FILE_INFO` key in `UserPreferencesRepository` to persist the preference.
- Expose `showPlayerFileInfo` state in `PlayerViewModel` and `SettingsViewModel`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.