Skip to content

feat: enhance player UI, library loading states, and performance conf…#1030

Merged
theovilardo merged 1 commit intomasterfrom
little-fixes-everywhere-4
Feb 10, 2026
Merged

feat: enhance player UI, library loading states, and performance conf…#1030
theovilardo merged 1 commit intomasterfrom
little-fixes-everywhere-4

Conversation

@theovilardo
Copy link
Copy Markdown
Owner

…iguration

  • Library:
    • Implement comprehensive Paging load state handling in LibrarySongsTab, adding a dedicated error UI with retry functionality and refined skeleton loading logic.
  • Full Player:
    • Improve progress bar smoothness by driving the slider thumb from smoothed progress and adjusting sampling rates based on expansion state.
    • Update default FullPlayerLoadingTweaks to enable placeholders and set the content appear threshold to 98% by default.
    • Refine placeholder logic in DelayedContent to ensure they only toggle during motion and stay open when fully expanded.
    • Adjust layout dimensions for controls and bottom toggle rows for better visual spacing.
    • Fix artist navigation to use the first valid artist ID from the song's metadata.
  • Navigation:
    • Optimize PlayerInternalNavigationBar by memoizing click listeners and using rememberUpdatedState to prevent unnecessary recompositions.
  • Build & Performance:
    • Enable R8 Full Mode in gradle.properties.
    • Update proguard-rules.pro to keep data and domain model members, ensuring compatibility with R8 full mode.

…iguration

- **Library**:
    - Implement comprehensive `Paging` load state handling in `LibrarySongsTab`, adding a dedicated error UI with retry functionality and refined skeleton loading logic.
- **Full Player**:
    - Improve progress bar smoothness by driving the slider thumb from smoothed progress and adjusting sampling rates based on expansion state.
    - Update default `FullPlayerLoadingTweaks` to enable placeholders and set the content appear threshold to 98% by default.
    - Refine placeholder logic in `DelayedContent` to ensure they only toggle during motion and stay open when fully expanded.
    - Adjust layout dimensions for controls and bottom toggle rows for better visual spacing.
    - Fix artist navigation to use the first valid artist ID from the song's metadata.
- **Navigation**:
    - Optimize `PlayerInternalNavigationBar` by memoizing click listeners and using `rememberUpdatedState` to prevent unnecessary recompositions.
- **Build & Performance**:
    - Enable R8 Full Mode in `gradle.properties`.
    - Update `proguard-rules.pro` to keep data and domain model members, ensuring compatibility with R8 full mode.
@theovilardo theovilardo merged commit 50853cc into master Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant