feat: enhance player UI, library loading states, and performance conf…#1030
Merged
theovilardo merged 1 commit intomasterfrom Feb 10, 2026
Merged
feat: enhance player UI, library loading states, and performance conf…#1030theovilardo merged 1 commit intomasterfrom
theovilardo merged 1 commit intomasterfrom
Conversation
…iguration
- **Library**:
- Implement comprehensive `Paging` load state handling in `LibrarySongsTab`, adding a dedicated error UI with retry functionality and refined skeleton loading logic.
- **Full Player**:
- Improve progress bar smoothness by driving the slider thumb from smoothed progress and adjusting sampling rates based on expansion state.
- Update default `FullPlayerLoadingTweaks` to enable placeholders and set the content appear threshold to 98% by default.
- Refine placeholder logic in `DelayedContent` to ensure they only toggle during motion and stay open when fully expanded.
- Adjust layout dimensions for controls and bottom toggle rows for better visual spacing.
- Fix artist navigation to use the first valid artist ID from the song's metadata.
- **Navigation**:
- Optimize `PlayerInternalNavigationBar` by memoizing click listeners and using `rememberUpdatedState` to prevent unnecessary recompositions.
- **Build & Performance**:
- Enable R8 Full Mode in `gradle.properties`.
- Update `proguard-rules.pro` to keep data and domain model members, ensuring compatibility with R8 full mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iguration
Pagingload state handling inLibrarySongsTab, adding a dedicated error UI with retry functionality and refined skeleton loading logic.FullPlayerLoadingTweaksto enable placeholders and set the content appear threshold to 98% by default.DelayedContentto ensure they only toggle during motion and stay open when fully expanded.PlayerInternalNavigationBarby memoizing click listeners and usingrememberUpdatedStateto prevent unnecessary recompositions.gradle.properties.proguard-rules.proto keep data and domain model members, ensuring compatibility with R8 full mode.