Merged
Conversation
- **Performance Optimizations**:
- Wrap `ImageRequest` in `remember` within `OptimizedAlbumArt` and `SmartImage` to prevent unnecessary object allocation and recompositions.
- Reduce recompositions in `MainActivity` and `QueueBottomSheet` by using `derivedStateOf` and `distinctUntilChanged` on player state flows.
- Remove `Trace` calls and unused variables/imports in `UnifiedPlayerSheet` and `FullPlayerContent`.
- Improve `QueueBottomSheet` efficiency by filtering out rapid position updates from the collected player state.
- **UI & Expansion Logic**:
- Fix "dead" touch zones in `DelayedContent` by forcing the gate open when the player is fully expanded.
- Ensure `FullPlayerContent` components are composed slightly before they become visible to improve interaction readiness.
- Decouple remote playback and Bluetooth state collection from nested composables in `FullPlayerContent` to improve stability.
- Update `contentAppearThresholdPercent` default from 100 to 0 and expand its slider range in Experimental Settings (0-100) for more flexible placeholder behavior.
- **Bug Fixes & Refinements**:
- Fix layout issues in `QueueBottomSheet` by ensuring height measurements are updated correctly on globally positioned events.
- Simplify `UnifiedPlayerSheet` by removing complex derived height calculations and unused alpha blending logic.
- Pass `isCastConnecting` state explicitly to sub-components in `FullPlayerContent`.
- **UI Enhancements**:
- Introduced `CircularWavyProgressIndicator` from Material3 Expressive API to indicate playback preparation in the mini-player.
- Added "Preparing playback..." and "Loading audio..." status text to the mini-player during song buffering.
- Improved color scheme transitions in `UnifiedPlayerSheet` to better sync with the currently active song and its album art.
- **Playback Logic**:
- Added a `preparingSongId` state to track and display the loading status of specific tracks.
- Updated `PlayerViewModel` to proactively trigger color scheme generation when a song begins preparing, improving theme responsiveness.
- Implemented logic to clear the "preparing" state once the media engine reports `STATE_READY` or playback begins.
- Refined mini-player visibility logic to ensure smoother entrance animations when a song is loaded.
- **Technical Improvements**:
- Exposed `currentAlbumArtUri` from `ThemeStateHolder` as a `StateFlow` to allow UI components to track the source of the current theme.
- Optimized color scheme selection logic to avoid flickering when transitioning between tracks with different artwork.
- Enabled `ExperimentalMaterial3ExpressiveApi` for advanced UI components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.