Refine full player expansion logic and enhance placeholder customization#1008
Merged
theovilardo merged 1 commit intomasterfrom Feb 8, 2026
Merged
Conversation
- **Full Player UI**:
- Replaces `Crossfade` with manual alpha blending in `DelayedContent` for smoother transitions between placeholders and actual content.
- Implements logic to track collapse/expand direction, allowing placeholders to be triggered at a specific "close threshold" when the player is dismissed.
- Refines placeholder components (`AlbumPlaceholder`, `MetadataPlaceholder`, `ProgressPlaceholder`, `ControlsPlaceholder`) to better match the visual density and layout of real components, including landscape support and audio metadata chips.
- Adds `graphicsLayer` transformations to placeholders to synchronize their appearance with the sheet expansion fraction.
- **Settings & Configuration**:
- Adds "Close threshold" slider to Experimental Settings to control when placeholders appear during collapse.
- Introduces a toggle to enable/disable placeholder delay specifically when closing the player.
- Renames "Full player content appear threshold" to "Expand threshold" for clarity.
- **Data & State**:
- Updates `FullPlayerLoadingTweaks` and `UserPreferencesRepository` to persist new threshold and close-behavior preferences.
- Adds corresponding setter methods in `SettingsViewModel`.
- **UI Refinements**:
- Adjusts padding in `BottomToggleRow` and layout spacing in `FullPlayerContent` for better visual alignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full Player UI:
Crossfadewith manual alpha blending inDelayedContentfor smoother transitions between placeholders and actual content.AlbumPlaceholder,MetadataPlaceholder,ProgressPlaceholder,ControlsPlaceholder) to better match the visual density and layout of real components, including landscape support and audio metadata chips.graphicsLayertransformations to placeholders to synchronize their appearance with the sheet expansion fraction.Settings & Configuration:
Data & State:
FullPlayerLoadingTweaksandUserPreferencesRepositoryto persist new threshold and close-behavior preferences.SettingsViewModel.UI Refinements:
BottomToggleRowand layout spacing inFullPlayerContentfor better visual alignment.