Skip to content

🏗 Add @babel/runtime as a dependency#22

Merged
themgoncalves merged 2 commits intomasterfrom
unknown repository
Aug 4, 2020
Merged

🏗 Add @babel/runtime as a dependency#22
themgoncalves merged 2 commits intomasterfrom
unknown repository

Conversation

@RDIL
Copy link
Copy Markdown
Contributor

@RDIL RDIL commented Jun 30, 2020 •
edited
Loading

Signed-off-by: Reece Dunham [email protected]

Summary

  • Updates some development dependencies
  • Adds @babel/runtime as a dependency

Why

The project currently breaks on Yarn v2 because @babel/plugin-transform-runtime calls @babel/runtime, which is not explicitly declared as one of the project's dependencies.

Checklist

  • Your code builds clean without any errors or warnings
  • You are using approved terminology
  • You have added unit tests, if apply.

@cspotcode
Copy link
Copy Markdown

cspotcode commented Jul 24, 2020

Any timeline on when this will be reviewed, merged, and released? I'm coming from facebook/docusaurus#3003

themgoncalves
themgoncalves requested changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@themgoncalves themgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RDIL, thanks for contribution, but sadly I cannot accept this pull request as it contains changes outside of the scope.

For that, I recommend you to only add the @babel/runtime into devDependencies (not dependencies itself) and remove all other changes that you made.

Cheers.

@themgoncalves
Copy link
Copy Markdown
Owner

themgoncalves commented Jul 27, 2020

@cspotcode per commend above.

@RDIL
Copy link
Copy Markdown
Contributor Author

RDIL commented Jul 27, 2020 •
edited
Loading

@themgoncalves I can revert the other changes, but this does need to be in normal dependencies, because it imports from the @babel/runtime at runtime.

@RDIL RDIL requested a review from themgoncalves July 27, 2020 17:21
@ylemkimon
Copy link
Copy Markdown

ylemkimon commented Aug 3, 2020

From @babel/plugin-transform-runtime docs:

Make sure you include @babel/runtime as a dependency.

themgoncalves
themgoncalves approved these changes Aug 4, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@themgoncalves themgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themgoncalves themgoncalves merged commit 5c07483 into themgoncalves:master Aug 4, 2020
@themgoncalves
Copy link
Copy Markdown
Owner

themgoncalves commented Aug 4, 2020

@RDIL, @ylemkimon you can find this merge in the just released v0.3.0.

@ylemkimon ylemkimon mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themgoncalves themgoncalves themgoncalves approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RDIL @cspotcode @themgoncalves @ylemkimon