-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Description
Thank you for this lib, it works great !
In my use case, i'd like to ignore the "invalid characters in fileName" errors, to automatically convert backslashes to forward slashes.
I read that @thejoshwolfe recommands using decodeStrings: false here: #54 (comment)
But as he mentions it:
You'll have to do some extra work to do UTF-8 vs CP437 decoding
It's too bad to do this extra work whereas the lib can do it, and this work isn't directly linked to the validation step. I'd like to create 2 different options:
autoValidateFileName: default true, if false, the methodvalidateFileNameisn't calleddecodeStrings: default true, if false, don't decode Buffer.
Or if my use case is not so specific, maybe we can add an option authorizeBackslash to avoid throwing an error in validateFileName.
What do you think about it ?
alonweiss-sl and kerenfi
Metadata
Metadata
Assignees
Labels
No labels