Repository navigation
fix(sync): remove replica vectors after remote tombstones - #5647
Merged
thedotmack merged 4 commits intoNov 9, 2026
Merged
thedotmack merged 4 commits into
thedotmack merged 4 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_019FbY8a4P6RjaWFnrGVZXnd
Owner
|
Merged, thank you @Afloat16! A pulled tombstone now also removes the deleted memory's vectors, so deleted content stops showing up as semantic-search candidates. Sharing one serial cleanup lane with local deletes is a nice consolidation. I merged main and dropped the generated bundles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Remote canonical tombstones delete replica SQLite rows but never delete their Chroma fragments. Backfill only visits existing SQLite rows, so deleted content stays indexed indefinitely and consumes semantic-search candidates. Origin IDs cannot identify replica vector rows.
Change
Capture the replica local row ID inside the tombstone transaction, then schedule the existing best-effort vector cleanup after commit, behind earlier same-row forwards. Extract the local-delete cleanup lane so local API deletes and replicated tombstones share one process-wide serial cleanup path. No new replay or inference work.
Validation
e5346179badbd8534e2983159d7be5684c4f7a44.