Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryAccepts decimal-string observation IDs while keeping the existing numeric-array, JSON-array, and CSV formats.
No actionable new issues were found. Tests were not run during this review. Reviews (2) · Last reviewed commit: "build(plugin): regenerate observation ID..." · Reviewed by Greptile |
Ship the numeric-string observation ID coercion in the committed worker bundle and its source map. Regenerated with the repository esbuild configuration and integrity checks, preserving the dependency versions in the original distribution. Validation: 14 focused regression tests passed under Node 24 / Vitest with bun:test imports adapted; emitted bundles pass node --check.
Carries the extra rejection cases from thedotmack#5339 into the route-level coercion tests. The new cases are booleans, null, decimals, exponents and blank strings. Co-authored-by: Afloat <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]>
) * fix(worker): accept numeric-string ids in /api/observations/batch * test(worker): cover more invalid observation id elements Carries the extra rejection cases from #5339 into the route-level coercion tests. The new cases are booleans, null, decimals, exponents and blank strings. Co-authored-by: Afloat <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]> --------- Co-authored-by: Alex Newman <[email protected]> Co-authored-by: Afloat <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
|
Thank you @Afloat16! I'm closing this because #5336 landed the same fix for #5335 (de134d3), and it needed fewer changes because Your extra rejection cases ( |
Summary
Fixes #5335.
The worker observations batch route accepts native numeric arrays, JSON-encoded numeric arrays, and CSV strings, but rejects per-element decimal strings such as
["56390", "56391"]. The shared MCP tool can legitimately lead callers to use string ids, so this costs a failed worker request and an extra turn.Normalize decimal-string elements before integer validation. Keep native numeric arrays and the existing whole-array/CSV formats. Cloud ids, blank strings, booleans, null, and non-integer strings remain invalid. Extract the focused schema so it can be exercised without starting the worker, and add the matching route regressions.
Validation
bun:testaliased to Vitest.git diff --check: passed.bun -e 'console.log(1)'in this environment, so the route suite, full worker suite, and release-bundle build have not been claimed as passed.