Add json decode return type extension #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Jul 25, 2025
Khartir
force-pushed
the
add-json_decode-return-type-extension
branch
from
419b761 to
4d80fb2
Compare
staabm
reviewed
Jul 25, 2025
Contributor
Author
|
Hey would it be possible to make a new release for this? I would really like to add this to our project. |
Collaborator
|
@shish not sure whether we need manual steps for a release. can I just tag a new release? |
Collaborator
|
@staabm I believe it's just pushing a new tag, yeah - at least I don't have anything special in my notes 😅 |
Collaborator
Contributor
Author
|
Thank you both for the quick reaction. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a version of PHPStan's
JsonThrowOnErrorDynamicReturnTypeExtensionto handle the return types of\Safe\json_decode.I also took the liberty to fix a failing test.
There is also a PR open in PHPStant to remove the deprecatedinstanceofchecks: phpstan/phpstan-src#4155No longer relevant