Repository navigation
fix(renderer): collect audio sources from every page - #27
Open
elwizard33 wants to merge 1 commit into
Open
elwizard33 wants to merge 1 commit into
elwizard33 wants to merge 1 commit into
Conversation
With concurrency > 1, an <Audio> registers only in the tabs whose frames mounted it, but audio sources were read from pages[0] alone. Clips that mounted only on frames rendered by other tabs were dropped from the mix. Read every page and merge by the registration key.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
renderFramesonly readwindow.__RENDIV_AUDIO_SOURCES__frompages[0], so withconcurrency > 1, a clip that only mounted in another tab was missing from the mix. This reads the map from every page and merges the entries by their existing key, so a clip registered in several tabs still only shows up once. The change is only inrender-frames.ts.To check it, I rendered a 2-frame composition with
a.mp3at frame 0 andb.mp3at frame 1, withconcurrency: 2. On masteraudioSourcesonly hada.mp3; with this branch it has both. There's no automated test, since the renderer package doesn't have a test setup.