Repository navigation
Commit 5965304
fix(studio): play after switching compositions and timeline scroll bounce
Play button: the Player is keyed by composition id, so switching mounts a
fresh instance whose initial 'pause'/'frameupdate' events fire from its own
mount effects before Preview's effect subscribes. Preview kept isPlaying=true
from the previous composition, so the play button called pause() on an
already-paused player and nothing happened. Preview now seeds isPlaying and
the current frame from the new player when it subscribes.
Timeline scroll: the track area's scrollLeft was mirrored into React state,
written back to the element from a passive effect, and fed again from
onScroll. When the element moved between a state update and its effect
(scrollbar drag, momentum, long frames during playback) the effect wrote the
older value back and the scrollbar bounced. Scroll position now lives only in
the DOM: wheel scrolling moves the element directly, and a zoom anchor is
applied once in a layout effect after the new width renders. Consecutive
ctrl+wheel events also continue from the pending zoom instead of a stale
pixels-per-frame, so a fast zoom no longer drops steps.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 6d6aca2 commit 5965304
3 files changed
Lines changed: 48 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
115 | 127 | | |
116 | 128 | | |
117 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | 111 | | |
118 | 112 | | |
119 | 113 | | |
| |||
270 | 264 | | |
271 | 265 | | |
272 | 266 | | |
273 | | - | |
274 | 267 | | |
275 | 268 | | |
276 | 269 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | 10 | | |
13 | 11 | | |
14 | 12 | | |
15 | 13 | | |
16 | 14 | | |
17 | 15 | | |
18 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
19 | 27 | | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
23 | 31 | | |
24 | | - | |
25 | 32 | | |
26 | 33 | | |
27 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
28 | 46 | | |
29 | 47 | | |
30 | 48 | | |
31 | 49 | | |
32 | 50 | | |
| 51 | + | |
| 52 | + | |
33 | 53 | | |
34 | | - | |
35 | 54 | | |
36 | 55 | | |
37 | 56 | | |
| |||
46 | 65 | | |
47 | 66 | | |
48 | 67 | | |
| 68 | + | |
49 | 69 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
54 | 77 | | |
55 | | - | |
56 | 78 | | |
57 | | - | |
| 79 | + | |
58 | 80 | | |
59 | 81 | | |
60 | | - | |
| 82 | + | |
61 | 83 | | |
62 | 84 | | |
63 | 85 | | |
64 | | - | |
| 86 | + | |
65 | 87 | | |
0 commit comments