Repository navigation
Warn when the dependency diagram has no edges - #291
Merged
Merged
Conversation
Owner
|
Thanks! |
Owner
|
Included in v3.0.9 out soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235.
When no dependency edges survive discovery and filtering, pydeps can produce a blank diagram without an explanation. Warn with the target name and point to filters, --include-missing, debug logging, and the project issue tracker.
Keep graph output and exit behavior unchanged. JSON-only commands stay quiet. Tests use real temporary packages to cover unresolved imports, excluded dependencies, a healthy graph, and JSON-only output.
The two warning tests fail on the unchanged source. All four new tests pass with this change, and the full suite passes with 89 tests and two skips. Both changed files pass strict Flake8 with the CI line-length setting.
Full strict lint still reports 26 existing findings, reproduced on the unmodified baseline and unrelated to this change (CI's lint job runs with --exit-zero and is unaffected). Sphinx doc builds could not be verified locally because Python's documentation inventory endpoint returned HTTP 503.