fix: echo request Origin for /storage so credentialed cross-origin fetches work#2439
Merged
hsluoyz merged 1 commit intoJul 6, 2026
Conversation
…oss-origin The static file route replied with Access-Control-Allow-Origin: * while also sending Access-Control-Allow-Credentials: true. Browsers reject a wildcard Allow-Origin on a credentialed request, so the file-preview fetch (which uses credentials: "include") failed with "Failed to fetch" whenever the frontend and backend are served from different origins — e.g. the dev server on :13001 hitting the backend on :14000. Echo the request Origin instead (matching what CorsFilter already does for /api), falling back to "*" for same-origin / non-CORS requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The static file route replied with Access-Control-Allow-Origin: * while also sending Access-Control-Allow-Credentials: true. Browsers reject a wildcard Allow-Origin on a credentialed request, so the file-preview fetch (which uses credentials: "include") failed with "Failed to fetch" whenever the frontend and backend are served from different origins — e.g. the dev server on :13001 hitting the backend on :14000. Echo the request Origin instead (matching what CorsFilter already does for /api), falling back to "*" for same-origin / non-CORS requests.