Skip to content

Commit 1010447

Browse files
committed
Quote the test glob so the runner finds files on Node 24
CI failed on the Test step: node --test lib/ was resolved as a module path rather than a directory to search, and Node 24 has no directory discovery — the argument is matched as a literal glob, resolves to the directory itself, and then gets run as a test file (nodejs/node#64555). The local machine is on Node 26, where the same command worked, which is why it passed here and failed there. The repo pins 24.x in engines and CI, and that pin is deliberate: a previous commit moved CI to 24 because it had been validating a runtime nothing deployed on. node --test "lib/*.test.ts" is the documented form. The quotes matter and have to be double: an unquoted pattern is expanded by the shell rather than by Node, which is why it works interactively and fails under a package script on a different shell. Verified on node 24.20.0, the version CI runs: the directory form fails with MODULE_NOT_FOUND, the quoted glob passes 17. The full gate — lint, typecheck, test, build — passes on 24 as well as on the local 26.
1 parent fd06ce4 commit 1010447

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎apps/web/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"build": "next build",
88
"start": "next start -p 8300",
99
"typecheck": "tsc --noEmit",
10-
"test": "node --test lib/"
10+
"test": "node --test \"lib/*.test.ts\""
1111
},
1212
"dependencies": {
1313
"@mdx-js/loader": "^3.1.1",

0 commit comments

Comments
 (0)