Skip to content

FQDN Validation: FQDNs with fourth-level domain aren't considered valid #180

Description

@handymenny

Bug Description

If I sumbit an FQDN with a fourth-level domain, hyperglass responds with this error: 'XXX is not a valid Traceroute target'.

An example of valid domains that trigger this error are:

  • ec2-18-194-0-252.eu-central-1.compute.amazonaws.com
  • r3.sn-fpoq-o52l.googlevideo.com

Expected behavior

hyperglass should consider these domains valid and proceed with DNS resolution

Possible Solution

Replace fqdnPattern regex with:
/^(?!:\/\/)([a-zA-Z0-9-]+\.)*[a-zA-Z0-9-][a-zA-Z0-9-]+\.[a-zA-Z-]{2,6}?$/im

Metadata

Metadata

Assignees

Labels

acceptedIssue is confirmed and will be worked onbugConfirmed bug or unexpected behaviorfixed-in-next-releaseIssue has already been fixed in the next release

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions