Set grpcserver.WithKeepaliveEnforcement to 10s to match the client keepalive interval#8799
Merged
GiedriusS merged 2 commits intoMay 5, 2026
Merged
Conversation
jdgeisler
force-pushed
the
fix-grpc-keepalive-enforcement
branch
from
April 30, 2026 21:30
fb6cdbc to
1166621
Compare
Signed-off-by: James Geisler <[email protected]>
jdgeisler
force-pushed
the
fix-grpc-keepalive-enforcement
branch
from
May 4, 2026 15:48
1166621 to
e07785d
Compare
…the client keepalive interval Signed-off-by: James Geisler <[email protected]>
jdgeisler
force-pushed
the
fix-grpc-keepalive-enforcement
branch
from
May 4, 2026 16:10
e07785d to
5940c31
Compare
jdgeisler
changed the title
GiedriusS
approved these changes
May 5, 2026
GiedriusS
enabled auto-merge
May 5, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When using the distributed query engine, we noticed an issue where the queriers would return the error
ENHANCE_YOUR_CALM / too_many_pings.The Thanos grpc client sends keepalive pings every 10s, but without an explicit
KeepaliveEnforcementPolicyonthe server, the go grpc library default min time of 5 minutes is used. This causes the server to reject the second ping with
ENHANCE_YOUR_CALM / too_many_pings, dropping the connection.Setting a
KeepaliveEnforcementPolicywithMinTime: 10son all gRPC servers to match the client keep alive interval resolves this issue.Verification
Before configuring the
KeepaliveEnforcementPolicyto 10s.After configuring the
KeepaliveEnforcementPolicyto 10s. The error no longer occurs.