queryrange: fix panic in AnalyzesMerge due to wrong slice index#8701
Merged
GiedriusS merged 1 commit intoMar 9, 2026
Merged
Conversation
fpetkovski
approved these changes
Mar 4, 2026
AnalyzesMerge incorrectly indexed the top-level 'analysis' variadic parameter instead of the loop-local 'elements' slice when accumulating execution times. When the analysis tree had more nodes than the number of analyses being merged, this caused an index-out-of-range panic. This was reported in production environments running Thanos v0.37.2 and v0.38, where the query frontend would panic during response merging. The fix replaces 'analysis[i]' with the correct 'elements[i]' and adds comprehensive test coverage for AnalyzesMerge, including the exact scenario that triggered the panic. Fixes thanos-io#8128 Signed-off-by: bejaratommy <[email protected]>
bejaratommy
force-pushed
the
fix/analyzes-merge-index-panic
branch
from
March 4, 2026 13:31
9c872ed to
41efdcb
Compare
Author
|
@fpetkovski DCO fixed |
GiedriusS
enabled auto-merge
March 9, 2026 08:12
Author
|
@GiedriusS @fpetkovski I don't think any of the CI failures are related, are they? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AnalyzesMerge incorrectly indexed the top-level 'analysis' variadic parameter instead of the loop-local 'elements' slice when accumulating execution times. When the analysis tree had more nodes than the number of analyses being merged, this caused an index-out-of-range panic.
This was reported in production environments running Thanos v0.37.2 and v0.38, where the query frontend would panic during response merging.
The fix replaces 'analysis[i]' with the correct 'elements[i]' and adds comprehensive test coverage for AnalyzesMerge, including the exact scenario that triggered the panic.
Fixes #8128
Verification
PR includes several tests.