While we are at it; wdyt of making batch size part of the client request?.that way it's forwards and backwards compatible

While we are at it; wdyt of making batch size part of the client request?.that way it's forwards and backwards compatible

Sorry, could you elaborate? It is part of SeriesRequest right now [1] and it's propagated through NewQueryableCreator

[1] -

While we are at it; wdyt of making batch size part of the client request?.that way it's forwards and backwards compatible

Sorry, could you elaborate? It is part of SeriesRequest right now [1] and it's propagated through NewQueryableCreator

[1] -

thanos/pkg/store/storepb/rpc.proto

Lines 115 to 117 in 49dde50

	// response_batch_size is used to batch Series messages into one SeriesResponse
	// If set to 0 or 1, each Series is sent as a separate response
	int64 response_batch_size = 16;

[2] -

thanos/cmd/thanos/query.go

Lines 459 to 467 in 49dde50

	queryableCreator = query.NewQueryableCreator(
	logger,
	extprom.WrapRegistererWithPrefix("thanos_query_", reg),
	seriesProxy,
	maxConcurrentSelects,
	queryTimeout,
	deduplicationFunc,
	seriesResponseBatchSize,
	)

Ah nice nevermind I brainfarted