compact: ignore blocks with deletion mark in partial deletes#8410
Merged
Conversation
Blocks deletion always starts with meta.json so if there are multiple shards of the compactor then one shard can also start to try to delete the same block because it detects them as partial. Hence, ignore deletion marks in the partial block cleaning function because blocks with deletion mark as handled in the other flow. Signed-off-by: Giedrius Statkevičius <[email protected]>
adezxc
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks deletion always starts with meta.json so if there are multiple shards of the compactor then one shard can also start to try to delete the same block because it detects them as partial. Hence, ignore deletion marks in the partial block cleaning function because blocks with deletion mark as handled in the other flow.