build(deps): update objstore to the latest#8162
Open
tritone wants to merge 3 commits intothanos-io:mainfrom
Open
build(deps): update objstore to the latest#8162tritone wants to merge 3 commits intothanos-io:mainfrom
tritone wants to merge 3 commits intothanos-io:mainfrom
Conversation
Updates objstore to HEAD. Also transitively picks up updates for the GCS SDK (see #thanos-io/objstore#165). Also removes replace statement pinning google.golang.org/grpc. Issue which was referenced in the comment (#grpc/grpc-go#7314) is now resolved.
tritone
changed the title
Member
|
Unfortunately there was a breaking change in the main package in objstore: thanos-io/objstore#155 @fpetkovski might have more context, but we need manual changes to fix this. @tritone do you want to take a stab on resolving? If not, perhaps one of the @thanos-io/thanos-maintainers has time to do the refactor. |
Contributor
|
We added a new method to the interface, so we probably need to propagate that to all implementations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates objstore to HEAD. Also transitively picks up updates for the GCS SDK (see thanos-io/objstore#165).
Also removes replace statement pinning google.golang.org/grpc. Issue which was referenced in the comment (grpc/grpc-go#7314) is now resolved.
I had to make the following additional changes to handle breaking changes in dependencies:
Changes
Verification
make depsandmake buildpass locally. I could use some help debugging the presubmit failures.